[CALCITE-6643] Char_Length Function is not recognized in PrestoSql. Add LENGTH function in PrestoSqlDialect#4017
Merged
mihaibudiu merged 1 commit intoapache:mainfrom Oct 25, 2024
Conversation
vikramahuja1001
changed the title
Contributor
|
the commit message should match the JIRA issue and PR title |
vikramahuja1001
changed the title
vikramahuja1001
changed the title
vikramahuja1001
force-pushed
the
PrestoSqlLengthFix
branch
from
5a0c274 to
fde0107
Compare
Contributor
Author
|
@mihaibudiu i have updated the same. Thanks for letting me know. |
mihaibudiu
approved these changes
Oct 25, 2024
Contributor
mihaibudiu
left a comment
mihaibudiu
left a comment
There was a problem hiding this comment.
Haven't checked the presto spec, but assuming this is right, the PR looks fine.
mihaibudiu
added
the
LGTM-will-merge-soon
caicancai
approved these changes
Oct 25, 2024
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
Show resolved
Hide resolved
…dd LENGTH function in PrestoSqlDialect
vikramahuja1001
force-pushed
the
PrestoSqlLengthFix
branch
from
fde0107 to
0edaf64
Compare
|
Contributor
Author
|
Thanks for the review @mihaibudiu , @caicancai |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PrestoSqlDialect by default will change any length function in a query to char_length function but char_length function is not available/supported in PrestoSql.
Add length function support in PrestoSqlDialect