[CALCITE-6693] Add Source SQL Dialect to RelToSqlConverterTest#4050
[CALCITE-6693] Add Source SQL Dialect to RelToSqlConverterTest#4050hannerwang wants to merge 1 commit intoapache:mainfrom
Conversation
|
Please fix CLI |
hannerwang
force-pushed
the
null_collation_order_by_mismatch
branch
from
db271e5 to
2002efa
Compare
|
Thanks for the reminder, it's fixed. |
mihaibudiu
left a comment
mihaibudiu
left a comment
There was a problem hiding this comment.
I am approving this, let's see if anyone has any other comments.
| + "GROUP BY `product_class_id`, `product_id` WITH CUBE"; | ||
| sql(query).withHive().ok(expected); | ||
| SqlDialect sqlDialect = sql(query).withHive().dialect; | ||
| SqlDialect sqlDialect = sql(query).withHive().targetDialect; |
There was a problem hiding this comment.
I think this is a very useful change, the naming is indeed confusing.
mihaibudiu
added
the
LGTM-will-merge-soon
|
-1 let's discuss in jira |
mihaibudiu
removed
the
LGTM-will-merge-soon
|
removed label until the discussion in JIRA is settled. |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@calcite.apache.org list. Thank you for your contributions. |
4 participants
What changes were proposed in this pull request?
Add Source SQL Dialect to RelToSqlConverterTest to make dialect translation more clear.
Why are the changes needed?
Currently, RelToSqlConverterTest converts the original SQL to RelNode using the default validator config and the target dialect's type system, which is confusing. We should ensure the conversion conforms to the source dialect's specifications, and then convert from the source dialect's RelNode to the target dialect's SQL.
Does this PR introduce any user-facing change?
Yes, the null collation the PlannerImpl use will be validator config's null collation when calcite connection property unset.