[CALCITE-5590] NullPointerException when converting 'in' expression that is used inside select list and group by#4058
Merged
dssysolyatin merged 1 commit intoapache:mainfrom Nov 22, 2024
Conversation
dssysolyatin
force-pushed
the
CALCITE-5590-v2
branch
from
ba12af9 to
f9fa12e
Compare
mihaibudiu
approved these changes
Nov 21, 2024
Contributor
mihaibudiu
left a comment
mihaibudiu
left a comment
There was a problem hiding this comment.
This looks a bit like magic, but it seems to work based on the tests.
dssysolyatin
force-pushed
the
CALCITE-5590-v2
branch
from
f9fa12e to
2beda5b
Compare
Contributor
Author
|
@mihaibudiu @caicancai Thanks for reviewing. I made one more small change—I added a test case from the task https://issues.apache.org/jira/browse/CALCITE-4549 to ensure that it also works. |
…hat is used inside select list and group by
dssysolyatin
force-pushed
the
CALCITE-5590-v2
branch
from
2beda5b to
0277b2e
Compare
|
caicancai
reviewed
Nov 22, 2024
| /** Test case for | ||
| * <a href="https://issues.apache.org/jira/browse/CALCITE-4549">[CALCITE-4549] | ||
| * IndexOutOfBoundsException when group view by a sub query</a>. */ | ||
| @Test void testGroupView() { |
Member
There was a problem hiding this comment.
Maybe the test name could be improved, but it doesn't seem to matter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that almost all deleted lines are from my incorrect previous fix for task CALCITE-5209