Skip to content

[CALCITE-6705] Allow for dialect-specific unparsing for numeric literals #4064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tanclary merged 1 commit into from
Nov 25, 2024
Merged

[CALCITE-6705] Allow for dialect-specific unparsing for numeric literals #4064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/src/main/java/org/apache/calcite/sql/SqlDialect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,11 @@ public void unparseDateTimeLiteral(SqlWriter writer,
writer.literal(literal.toString());
}

public void unparseNumericLiteral(SqlWriter writer,
String value, int leftPrec, int rightPrec) {
writer.literal(value);
}

public void unparseSqlDatetimeArithmetic(SqlWriter writer,
SqlCall call, SqlKind sqlKind, int leftPrec, int rightPrec) {
final SqlWriter.Frame frame = writer.startList("(", ")");
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/java/org/apache/calcite/sql/SqlNumericLiteral.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public boolean isExact() {
SqlWriter writer,
int leftPrec,
int rightPrec) {
writer.literal(toValue());
writer.getDialect().unparseNumericLiteral(writer, toValue(), leftPrec, rightPrec);
}

@Override public String toValue() {
Expand Down