Skip to content

[CALCITE-6707] Type inference for CHR function is wrong #4067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mihaibudiu merged 1 commit into from
Nov 28, 2024
Merged

[CALCITE-6707] Type inference for CHR function is wrong #4067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2284,7 +2284,7 @@ private static RelDataType deriveTypeMapFromEntries(SqlOperatorBinding opBinding
@LibraryOperator(libraries = {BIG_QUERY, ORACLE, POSTGRESQL})
public static final SqlFunction CHR =
SqlBasicFunction.create("CHR",
ReturnTypes.CHAR,
ReturnTypes.CHAR_NULLABLE_IF_ARGS_NULLABLE,
OperandTypes.INTEGER,
SqlFunctionCategory.STRING);

Expand Down
7 changes: 7 additions & 0 deletions core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,13 @@ public static SqlCall stripSeparator(SqlCall call) {
public static final SqlReturnTypeInference CHAR_FORCE_NULLABLE =
CHAR.andThen(SqlTypeTransforms.FORCE_NULLABLE);

/**
* Type-inference strategy whereby the result type of a call is
* CHAR(1), nullable if any argument is nullable.
*/
public static final SqlReturnTypeInference CHAR_NULLABLE_IF_ARGS_NULLABLE =
CHAR.andThen(SqlTypeTransforms.TO_NULLABLE);

/**
* Type-inference strategy whereby the result type of a call is a TINYINT.
*/
Expand Down
3 changes: 3 additions & 0 deletions testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2213,6 +2213,9 @@ void testCastToBoolean(CastType castType, SqlOperatorFixture f) {
f.checkScalar("chr(48)", "0", "CHAR(1) NOT NULL");
f.checkScalar("chr(0)", String.valueOf('\u0000'), "CHAR(1) NOT NULL");
f.checkNull("chr(null)");
// Test case for [CALCITE-6707] Type inference for CHR function is wrong
// https://issues.apache.org/jira/browse/CALCITE-6707
f.checkType("chr(CAST(null AS INTEGER))", "CHAR(1)");
};
final List<SqlLibrary> libraries =
list(SqlLibrary.BIG_QUERY, SqlLibrary.ORACLE, SqlLibrary.POSTGRESQL);
Expand Down