[CALCITE-6724] MockTable support for multiple (individual & composite) keys#4083
Merged
zabetak merged 1 commit intoapache:mainfrom Dec 10, 2024
Merged
[CALCITE-6724] MockTable support for multiple (individual & composite) keys#4083zabetak merged 1 commit intoapache:mainfrom
zabetak merged 1 commit intoapache:mainfrom
Conversation
…) keys MockTable currently allows only one key to be specified; the key can be either simple or composite. In real scenarios though a table can have multiple keys.
|
ILuffZhe
approved these changes
Dec 10, 2024
testkit/src/main/java/org/apache/calcite/test/catalog/MockCatalogReader.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MockTable currently allows only one key to be specified; the key can be either simple or composite. In real scenarios though a table can have multiple keys.
MockTable#addKeyAPI to explicitly support multiple (individual & composite) keys.MockTable#addColumnto create individual keys whenisKeyistrue. There is a slight change in behavior since when the method is called multiple times for the same table it will now create multiple simple keys instead of one composite.