SortCollapseRule for collapsing nested sorts.#410
Closed
gianm wants to merge 3 commits intoapache:masterfrom
Closed
SortCollapseRule for collapsing nested sorts.#410gianm wants to merge 3 commits intoapache:masterfrom
gianm wants to merge 3 commits intoapache:masterfrom
Conversation
Useful for subqueries like SELECT * FROM (...) LIMIT X, where the inner query might have an order by or limit.
Contributor
Author
|
A test that seems unrelated failed on jdk8: https://travis-ci.org/apache/calcite/builds/213303516 |
jcamachor
reviewed
Mar 22, 2017
Contributor
jcamachor
left a comment
jcamachor
left a comment
There was a problem hiding this comment.
We have a similar rule in Hive that I just realized that we never ported back to Calcite. New rule LGTM, it seems to have the same four different cases: https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortMergeRule.java
julianhyde
added a commit
to julianhyde/calcite
that referenced
this pull request
Mar 30, 2017
julianhyde
added a commit
to julianhyde/calcite
that referenced
this pull request
Mar 30, 2017
Contributor
Author
|
Fixed a bug with preservation of asc/desc ordering, and added a test for that. |
Contributor
Author
|
Closing as discussed in https://issues.apache.org/jira/browse/CALCITE-1719. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful for subqueries like
SELECT * FROM (...) LIMIT X, where the innerquery might have an order by or limit.