[CALCITE-6748] RelToSqlConverter returns the wrong result when Aggregate is on Sort#4117
Merged
mihaibudiu merged 1 commit intoapache:mainfrom Jan 7, 2025
Merged
Conversation
mihaibudiu
reviewed
Dec 28, 2024
| return true; | ||
| } | ||
|
|
||
| if (rel instanceof Aggregate |
Contributor
There was a problem hiding this comment.
seems you need an extra check for null here
Contributor
Author
There was a problem hiding this comment.
Done, the wrong reference object was used here.
suibianwanwank
force-pushed
the
calcite-6748
branch
from
5648417 to
47128e4
Compare
NobiGo
approved these changes
Dec 31, 2024
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
Show resolved
Hide resolved
ILuffZhe
reviewed
Jan 2, 2025
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
Show resolved
Hide resolved
ILuffZhe
approved these changes
Jan 7, 2025
Contributor
ILuffZhe
left a comment
ILuffZhe
left a comment
There was a problem hiding this comment.
Can you squash the commits? I think this PR is ready to merge.
suibianwanwank
force-pushed
the
calcite-6748
branch
from
cf7d696 to
ecddecd
Compare
|
ILuffZhe
added
the
LGTM-will-merge-soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.