[CALCITE-6744] RelMetadataQuery.getColumnOrigins should return null when column origin includes correlation variables

[suibianwanwank]

…lation variable

[suibianwanwank]

The logic here doesn't seem to fit the documentation.
set of origin columns, or null if this information cannot be determined (whereas empty set indicates definitely no origin columns at all)

[mihaibudiu]

why does this indicate an access in a correlated variable?
could this be an access into a field with type ROW?

[suibianwanwank]

You're right, there's a processing problem here. I fixed it.

[dssysolyatin]

I think there is a bug. What if fieldAccess.getReferenceExpr() is input ref ? For example: 'struct_column.field1.field2'. struct_column is InputRef.

Or:

$cor0.struct_field.field_1

I think implementation should be:

@Override public Void visitFieldAccess(RexFieldAccess fieldAccess) {
      if (fieldAccess.getReferenceExpr() instanceof RexCorrelVariable) {
              throw Util.FoundOne.NULL;
            }
        return super.visitFieldAccess(fieldAccess)
}

Or probably just use

@Override public R visitCorrelVariable(RexCorrelVariable correlVariable) {
    throw Util.FoundOne.NULL;
  }

[mihaibudiu]

@dssysolyatin comments on a closed PR will be easy to overlook, if you think there is a problem, please file another JIRA issue.

[mihaibudiu]

PR and commit should match JIRA

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[suibianwanwank]

PR and commit should match JIRA

Done.