[CALCITE-6817] Add string representation of default nulls direction for RelNode#4184
Merged
ILuffZhe merged 1 commit intoapache:mainfrom Feb 10, 2025
Merged
[CALCITE-6817] Add string representation of default nulls direction for RelNode#4184ILuffZhe merged 1 commit intoapache:mainfrom
ILuffZhe merged 1 commit intoapache:mainfrom
Conversation
ILuffZhe
force-pushed
the
CALCITE-6817
branch
2 times, most recently
from
ca4a128 to
8641493
Compare
Contributor
|
LGTM |
suibianwanwank
approved these changes
Feb 8, 2025
Contributor
suibianwanwank
left a comment
suibianwanwank
left a comment
There was a problem hiding this comment.
Overall LGTM, RelFieldCollation also exists in Window, would you consider adding it in this PR?
Contributor
Author
I assume you mean OVER call, like |
ILuffZhe
force-pushed
the
CALCITE-6817
branch
from
495fb3a to
16dc5a5
Compare
ILuffZhe
added
the
LGTM-will-merge-soon
|
caicancai
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.