[CALCITE-6877] Generate LogicalProject in RelRoot.project() when mapping is not name trivial#4230
Closed
nielspardon wants to merge 1 commit intoapache:mainfrom
Closed
[CALCITE-6877] Generate LogicalProject in RelRoot.project() when mapping is not name trivial#4230nielspardon wants to merge 1 commit intoapache:mainfrom
nielspardon wants to merge 1 commit intoapache:mainfrom
Conversation
…ing is not name trivial Signed-off-by: Niels Pardon <par@zurich.ibm.com>
|
mihaibudiu
approved these changes
Mar 7, 2025
Contributor
mihaibudiu
left a comment
mihaibudiu
left a comment
There was a problem hiding this comment.
Interesting that this does not affect any existing tests.
Contributor
Author
Indeed, I was also a bit suprised that this code has been there for 9 years and nobody has encountered this before. One thing I found was that when you start with a SQL statement through the SQL parser it combines the column reduction and renaming into a single |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/CALCITE-6877