[CALCITE-6900] Support Char type cast in ClickHouse Dialect#4253
[CALCITE-6900] Support Char type cast in ClickHouse Dialect#4253xuzifu666 wants to merge 1 commit intoapache:mainfrom
Conversation
xuzifu666
force-pushed
the
ck_char_support
branch
from
a7aa326 to
4d05cbb
Compare
| + "FROM `foodmart`.`product`"; | ||
| final String expectedSpark = "SELECT CAST(`product_id` AS CHAR(1))\n" | ||
| + "FROM `foodmart`.`product`"; | ||
| final String expectedClickHouse = "SELECT CAST(`product_id` AS `FixedString(1)`)\n" |
There was a problem hiding this comment.
assuming this indeed works in Clickhouse, this PR looks fine.
Has this been tested?
There was a problem hiding this comment.
Yes, had test for it. sql like:
select cast('a' as FixedString(1))from system.numbers limit 1;
and result return a.
There was a problem hiding this comment.
for some reason the CI on windows fails
There was a problem hiding this comment.
Windows ci error may not related to the changed code of this pr，in my repo test is all passed and also build success in local.
There was a problem hiding this comment.
@mihaibudiu It is the test in my repository and related CI is all passed and based with main branch latest commit.
|
I have already approved this. |
@mihaibudiu OK, I had open a new PR about it which CI all passed with the same code~ we can handle |
|
I have approved the other one |
2 participants
As descrption in JIRA: https://issues.apache.org/jira/browse/CALCITE-6900