[CALCITE-6145] Function 'TRIM' without parameters throw NullPointerException#4359
[CALCITE-6145] Function 'TRIM' without parameters throw NullPointerException#4359xiedeyantu wants to merge 1 commit intoapache:mainfrom
Conversation
mihaibudiu
added
the
LGTM-will-merge-soon
| "Invalid argument '': the length of the string describing " | ||
| + "the trimmed character must be 1", | ||
| true); | ||
| f.checkFails("trim()", "Invalid number of arguments to function 'TRIM'. Was expecting at least 2 arguments", false); |
There was a problem hiding this comment.
This test cannot pass...
There was a problem hiding this comment.
then the PR is incomplete
There was a problem hiding this comment.
Yes, give me some time and I'll see if I can handle it.
There was a problem hiding this comment.
Please remove the LGTM tag before I fix it.
mihaibudiu
removed
the
LGTM-will-merge-soon
|
At present, errors will occur during the parsing stage. If TRIM cannot accept empty parameters, then this should be reasonable. I also reported parsing errors when verifying in MySQL and PGSQL. So does this PR still need for the current code? |
There are compatibility issues in syntax here which would block horoughly fix. |
|
See https://issues.apache.org/jira/browse/CALCITE-6708 |
Yes, in my opinion, this PR can be closed now. WDYT? |
Do we still need to fix this error? I think it's reasonable. What's your opinion? |
|
I will mark the issue resolved, you can close this PR |
3 participants
Only squash the #3869 and rebase main.