Skip to content

[CALCITE-7210] BINARY literal values may not match their type#4565

Merged
mihaibudiu merged 2 commits intoapache:mainfrom
mihaibudiu:issue7210
Oct 2, 2025
Merged

[CALCITE-7210] BINARY literal values may not match their type#4565
mihaibudiu merged 2 commits intoapache:mainfrom
mihaibudiu:issue7210

Conversation

@mihaibudiu
Copy link
Contributor

I added a second commit adding my last blog post to the documentation, since it was approved by the reviewers.

Copy link
Member

@xiedeyantu xiedeyantu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


final SqlOperatorFixture f0 = fixture()
.setFor(SqlLibraryOperators.LEAST, VmName.EXPAND)
// for shouldConvertRaggedUnionTypes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to be changed to shouldConvertRaggedUnionTypesToVarying?

consider creating a pull request on GitHub. If you just finished a cool project using Calcite
consider writing a short article about it for our [news section]({{ site.baseurl }}/news/index.html).

* <a href="https://www.feldera.com/blog/constant-folding-in-calcite">Constant folding in Calcite</a> (Mihai Budiu, 2025)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent article!

Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
@xiedeyantu xiedeyantu added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Oct 2, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2025

@mihaibudiu mihaibudiu merged commit cf23c16 into apache:main Oct 2, 2025
23 of 38 checks passed
@mihaibudiu mihaibudiu deleted the issue7210 branch October 2, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LGTM-will-merge-soon Overall PR looks OK. Only minor things left.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants