Skip to content

[CALCITE-7441] AggregateFilterToFilteredAggregateRule fails when WHERE condition is nullable#4836

Merged
zabetak merged 1 commit intoapache:mainfrom
zabetak:CALCITE-7441
Mar 16, 2026
Merged

[CALCITE-7441] AggregateFilterToFilteredAggregateRule fails when WHERE condition is nullable#4836
zabetak merged 1 commit intoapache:mainfrom
zabetak:CALCITE-7441

Conversation

@zabetak
Copy link
Copy Markdown
Member

@zabetak zabetak commented Mar 13, 2026

Jira Link

CALCITE-7441

Changes Proposed

Modify rule to wrap nullable condition using the IS TRUE operator when transforming to filtered aggregate. The same logic exists when doing the SQL to RelNode conversion.

Copy link
Copy Markdown
Member

@asolimando asolimando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@xiedeyantu xiedeyantu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zabetak zabetak merged commit af6367d into apache:main Mar 16, 2026
17 of 18 checks passed
@zabetak zabetak deleted the CALCITE-7441 branch March 16, 2026 09:48
@zabetak
Copy link
Copy Markdown
Member Author

zabetak commented Mar 16, 2026

Many thanks for the reviews @asolimando @xiedeyantu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants