Skip to content

[CALCITE-7450 FOLLOW UP] Moved the newly added test to RelOptRulesTest, for consistency#4850

Merged
zabetak merged 1 commit intoapache:mainfrom
darpan-e6:CALCITE-7450-follow-up
Mar 27, 2026
Merged

[CALCITE-7450 FOLLOW UP] Moved the newly added test to RelOptRulesTest, for consistency#4850
zabetak merged 1 commit intoapache:mainfrom
darpan-e6:CALCITE-7450-follow-up

Conversation

@darpan-e6
Copy link
Copy Markdown
Contributor

@darpan-e6 darpan-e6 commented Mar 27, 2026

Jira Link

CALCITE-7450

Changes Proposed

Raising this PR as part of the suggestion I got in merged PR CALCITE-7450, to move the location of newly added test.

@darpan-e6
Copy link
Copy Markdown
Contributor Author

darpan-e6 commented Mar 27, 2026

@zabetak, made the changes according to conversation. Can you please review?

Copy link
Copy Markdown
Member

@caicancai caicancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@zabetak zabetak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick follow-up @darpan-e6 !

@darpan-e6
Copy link
Copy Markdown
Contributor Author

LGTM! Thanks for the quick follow-up @darpan-e6 !

Pleasure's mine 😁.

@zabetak zabetak force-pushed the CALCITE-7450-follow-up branch from 4173cf0 to 7fcfda6 Compare March 27, 2026 08:57
@zabetak
Copy link
Copy Markdown
Member

zabetak commented Mar 27, 2026

I amended the commit message with the Jira ID and will merge it once CI runs.

@sonarqubecloud
Copy link
Copy Markdown

@zabetak zabetak merged commit f768501 into apache:main Mar 27, 2026
19 checks passed
@zabetak
Copy link
Copy Markdown
Member

zabetak commented Mar 27, 2026

Thanks for the PR @darpan-e6 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants