Skip to content

[CALCITE-6968] SqlUpdate#getOperandList omits sourceSelect operand#4857

Merged
macroguo-ghy merged 1 commit intoapache:mainfrom
macroguo-ghy:calcite-6968
Apr 5, 2026
Merged

[CALCITE-6968] SqlUpdate#getOperandList omits sourceSelect operand#4857
macroguo-ghy merged 1 commit intoapache:mainfrom
macroguo-ghy:calcite-6968

Conversation

@macroguo-ghy
Copy link
Copy Markdown
Contributor

@macroguo-ghy macroguo-ghy commented Mar 30, 2026

Jira Link

CALCITE-6968

Changes Proposed

  • Fix SqlUpdate so its operand contract consistently includes the internal sourceSelect across getOperandList(), setOperand(), and OPERATOR.createCall(...).
  • Add regression coverage for operand symmetry, cloning, and unparse() behavior so the internal sourceSelect remains internal.

Copy link
Copy Markdown
Member

@caicancai caicancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one question

@caicancai caicancai added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Apr 5, 2026
@macroguo-ghy macroguo-ghy merged commit cde0fe5 into apache:main Apr 5, 2026
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LGTM-will-merge-soon Overall PR looks OK. Only minor things left.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants