[CALCITE-4868] Elasticsearch adapter fails if GROUP BY is followed by ORDER BY

[xuzifu666]

jira：https://issues.apache.org/jira/browse/CALCITE-4868

[snuyanzin]

mostly LGTM
the question I have is whether it makes sense to consider test cases with ordinals and aliases
like SqlConformance#isGroupByAlias and SqlConformance#isGroupByOrdinal, same for ORDER BY

[xuzifu666]

mostly LGTM the question I have is whether it makes sense to consider test cases with ordinals and aliases like SqlConformance#isGroupByAlias and SqlConformance#isGroupByOrdinal, same for ORDER BY

Thanks for the review @snuyanzin . I have added additional test cases; the current set of tests should now be sufficient to verify the fix for CALCITE-4868, for the following reasons:

1. The bug in question concerns a failure in the Elasticsearch adapter triggered specifically when an ORDER BY clause follows a GROUP BY clause.
2. The current tests successfully verify the core functionality: that aggregation combined with ORDER BY aliases works correctly.
3. Different SQL conformance settings primarily influence how aliases and ordinals are processed during the parsing phase, whereas the fix for the Elasticsearch adapter addresses the sorting logic during the execution phase.

[xiedeyantu]

Perhaps we can add test case for GROUP BY alias.

[xuzifu666]

Perhaps we can add test case for GROUP BY alias.

OK, had added related test case.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud