[CALCITE-7020] Upgrade gradle from 8.7 to 8.14.4#4880
[CALCITE-7020] Upgrade gradle from 8.7 to 8.14.4#4880snuyanzin wants to merge 1 commit intoapache:mainfrom
Conversation
| dirPermissions { | ||
| unix("775") | ||
| } | ||
| filePermissions { | ||
| unix("664") | ||
| } |
There was a problem hiding this comment.
dirMode and fileMode are deprecated
| /** Cassandra resource. */ | ||
| private static class CassandraResource | ||
| implements ExtensionContext.Store.CloseableResource { | ||
| implements AutoCloseable { |
There was a problem hiding this comment.
replace deprecated interface
| val testRuntimeOnly by configurations | ||
| testImplementation(platform("org.junit:junit-bom")) | ||
| testImplementation("org.junit.jupiter:junit-jupiter") | ||
| testRuntimeOnly("org.junit.platform:junit-platform-launcher") |
There was a problem hiding this comment.
kotlin 2.x requires this
| com.github.johnrengelman.shadow.version=5.1.0 | ||
| com.github.spotbugs.version=2.0.0 | ||
| com.github.vlsi.vlsi-release-plugins.version=1.90 | ||
| com.github.vlsi.vlsi-release-plugins.version=3.0.1 |
There was a problem hiding this comment.
a number of warnings came from old plugins
| asm.version=9.9.1 | ||
| byte-buddy.version=1.18.8 |
There was a problem hiding this comment.
prepare for newer java
| jsoup.version=1.11.3 | ||
| junit4.version=4.13.2 | ||
| junit5.version=5.9.1 | ||
| junit5.version=5.10.5 |
There was a problem hiding this comment.
kotlin 2.x requires at least 5.10.x
snuyanzin
changed the title
There was a problem hiding this comment.
I don't know how to review this change
|
I seem to recall that upgrading Gradle would impact Java 8 support, but the CI tests indicate that everything is fine. |
|
thank you for the review |
there was an issue with jacoco (because of stricter rules in newer gradle), finally I was able to resolve it (these lines https://github.com/apache/calcite/pull/4880/changes#diff-c0dfa6bc7a8685217f70a860145fbdf416d449eaff052fa28352c5cec1a98c06R291-R293) |
Thanks for the explanation. I don't fully understand this part, but judging by the test results, it looks good. |
|
Other dependencies also bumped com.github.vlsi.vlsi-release-plugins from 1.90 to 3.0.1 kotlin from 1.9.22 to 2.0.21 org.jetbrains.gradle.plugin.idea-ext from 0.5 to 1.4.1 jandex from 2.2.3.Final to 3.5.3 asm from 9.6 to 9.9.1 byte-buddy from 1.14.15 to 1.18.8 junit5 from 5.9.1 to 5.10.5
4 participants
Jira Link
CALCITE-7020
The PR bumps gradle to 8.14.4 and fixes gradle warnings