[CALCITE-1842] Wrong order of inputs for makeCost() call in Sort.computeSelfCost()#491
Closed
axeisghost wants to merge 1 commit intoapache:masterfrom
Closed
[CALCITE-1842] Wrong order of inputs for makeCost() call in Sort.computeSelfCost()#491axeisghost wants to merge 1 commit intoapache:masterfrom
axeisghost wants to merge 1 commit intoapache:masterfrom
Conversation
julianhyde
pushed a commit
to julianhyde/calcite
that referenced
this pull request
Jul 6, 2017
… in wrong order (Junxian Wu) Close apache#491
julianhyde
pushed a commit
to julianhyde/calcite
that referenced
this pull request
Jul 6, 2017
… in wrong order (Junxian Wu) Close apache#491
ldming
pushed a commit
to ldming/mycalcite
that referenced
this pull request
Sep 13, 2018
… in wrong order (Junxian Wu) Close apache/calcite#491
7mming7
pushed a commit
to Kyligence/calcite
that referenced
this pull request
Jan 23, 2021
… in wrong order (Junxian Wu) Close apache#491
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket 1842 addressed the problem already:
The mistake in the input computation of
Sortwill make the LIMIT does not get pushed into the Druid Query. The difference in performance can be huge.Right now this problem was reported only in Druid Adapter but this change is generic for all adapters, so specific Druid test cases were not created.
I did not find any test cases to check the cost of
RelNodeand do not know where to put the test cases if we want to test it out. If test cases are still necessary please let me know where to add.