Skip to content

[CALCITE-6291] Support converting ArrowTable to Queryable#4915

Merged
xuzifu666 merged 1 commit intoapache:mainfrom
xuzifu666:calcite-6291
May 6, 2026
Merged

[CALCITE-6291] Support converting ArrowTable to Queryable#4915
xuzifu666 merged 1 commit intoapache:mainfrom
xuzifu666:calcite-6291

Conversation

@xuzifu666
Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Member

@caicancai caicancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM

}
enumerator.close();

// Verify we got 6 rows
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment could perhaps be improved.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to add a comment here; I deleted it.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 5, 2026

@xuzifu666 xuzifu666 added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label May 6, 2026
@xuzifu666 xuzifu666 merged commit cf4ffc1 into apache:main May 6, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LGTM-will-merge-soon Overall PR looks OK. Only minor things left.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants