Skip to content

[CALCITE-7526] Incorrect TIMESTAMP WITH TIME ZONE produces wrong error message #4944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mihaibudiu merged 1 commit into from
May 14, 2026
Merged

[CALCITE-7526] Incorrect TIMESTAMP WITH TIME ZONE produces wrong error message #4944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/org/apache/calcite/util/TimestampWithTimeZoneString.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public TimestampWithTimeZoneString(String v) {

if (pos == -1) {
throw RESOURCE.illegalLiteral("TIMESTAMP WITH LOCAL TIME ZONE", v,
RESOURCE.badFormat(TIMESTAMP_FORMAT_STRING).str()).ex();
RESOURCE.badFormat(TIMESTAMP_FORMAT_STRING + " zone").str()).ex();
}

String tsStr = v.substring(0, pos);
Expand Down
14 changes: 14 additions & 0 deletions core/src/test/java/org/apache/calcite/rex/RexProgramTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3413,6 +3413,20 @@ private SqlOperator getNoDeterministicOperator() {
assertThat(timestampLTZChar1.equals(timestampLTZChar4), is(true));
}

/** Test case for <a href="https://issues.apache.org/jira/browse/CALCITE-7526">[CALCITE-7526]
* Incorrect TIMESTAMP WITH TIME ZONE produces wrong error message</a>. */
@Test void testMalformedTimezone() {
try {
new TimestampWithTimeZoneString("2011-07-20T10:34:56America/Los_Angeles");
} catch (Exception ex) {
assertThat(
ex.getMessage(), is("Illegal TIMESTAMP WITH LOCAL TIME ZONE literal "
+ "'2011-07-20T10:34:56America/Los_Angeles': not in format 'yyyy-MM-dd HH:mm:ss zone'"));
return;
}
fail("Should not be reached");
}

@Test void testSimplifyLiterals() {
final RexLiteral literalAbc = rexBuilder.makeLiteral("abc");
final RexLiteral literalDef = rexBuilder.makeLiteral("def");
Expand Down
Loading