Addendum to [CALCITE-7475]: correction for unparse method#4946
Merged
Conversation
Contributor
Author
Dwrite
approved these changes
May 15, 2026
caicancai
approved these changes
May 15, 2026
Member
caicancai
left a comment
caicancai
left a comment
There was a problem hiding this comment.
Strange, I seem to remember that Calcite commit messages don't allow "fix" to start with.
Contributor
Author
|
I will change the commit message |
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
mihaibudiu
changed the title
mihaibudiu
added
the
LGTM-will-merge-soon
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7475
Changes Proposed
This fix prevents crashes during unparse of expressions involving
::