[CALCITE-7537] Invalid Postgres SQL generated for right-deep comma jo…#4951
Merged
asolimando merged 1 commit intoMay 21, 2026
Conversation
mihaibudiu
approved these changes
May 20, 2026
asolimando
force-pushed
the
alessandro.solimando/CALCITE-7537/right-deep-comma-join
branch
from
0e17c4b to
76cef63
Compare
Member
Author
|
@mihaibudiu sorry for the force push, I worked on a stale branch and the test I added needed to be updated, I have just changed the tables in the example to avoid collisions in "SELECT *" which in such case gets expanded to the full list of columns for Postgres, which made the test fail. TLDR: no major changes, just the test table names |
|
Member
Author
|
I will give it ~24 hours before merging it, in case anyone has further comments |
xiedeyantu
approved these changes
May 20, 2026
xuzifu666
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…in trees
Jira Link
CALCITE-7537
All details in the ticket