CALC-1803 Related, Cleaned up the flow control logic#499
Closed
axeisghost wants to merge 2 commits intoapache:masterfrom
Closed
CALC-1803 Related, Cleaned up the flow control logic#499axeisghost wants to merge 2 commits intoapache:masterfrom
axeisghost wants to merge 2 commits intoapache:masterfrom
Conversation
julianhyde
reviewed
Jul 18, 2017
| //fallthrough | ||
| break; | ||
| default: | ||
| rowBuilder.set(i, s); |
Contributor
There was a problem hiding this comment.
Why did you remove this line "rowBuilder.set(i, s);"? We still want to set the value if the type is not numeric.
Author
There was a problem hiding this comment.
Oh, It is totally my bad. I haven't touched this part for a while, so I kinda forget the original purpose of default branch.
Contributor
There was a problem hiding this comment.
I modified your code so that exceptional conditions throw or return, and non-exceptional conditions all go through the same 'rowBuilder.set(i, s)'. See julianhyde@cbbe627, and let me know if there's a problem. Otherwise I'll commit shortly.
Author
|
added the line back |
Author
|
Thank you. It is good. Thanks for helping me fix the logic. |
7mming7
pushed a commit
to Kyligence/calcite
that referenced
this pull request
Jan 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code coverity found out problem about flow control, mention in comments at CALC-1803