Skip to content

[CALCITE-1954] SqlValidator should maintain nullability across joins … #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
minji-kim wants to merge 1 commit into from
Closed

[CALCITE-1954] SqlValidator should maintain nullability across joins … #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2003,7 +2003,7 @@ private SqlNode registerFrom(
usingScope,
alias,
new AliasNamespace(this, call, enclosingNode),
false);
forceNullable);
}
return node;
case MATCH_RECOGNIZE:
Expand Down
11 changes: 11 additions & 0 deletions core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4127,6 +4127,17 @@ public void _testWinPartClause() {
"RANK or DENSE_RANK functions require ORDER BY clause in window specification");
}

@Test public void testLeftOuterJoinWithAlias() {
final String query =
"select * from "
+ "(select row_number() over (order by sal) from emp) as emp1(r1) "
+ "left outer join "
+ "(select dense_rank() over(order by sal) from emp) as emp2(r2) "
+ "on (emp1.r1 = emp2.r2)";
// In this case, R2 is nullable in the join since we have a left outer join.
sql(query).type("RecordType(BIGINT NOT NULL R1, BIGINT R2) NOT NULL");
}

@Test public void testInvalidWindowFunctionWithGroupBy() {
sql("select max(^empno^) over () from emp\n"
+ "group by deptno")
Expand Down