[CALCITE-1913] Make SqlDialect pluggable and remove DatabaseProduct uses#540
Closed
beikov wants to merge 2 commits intoapache:masterfrom
Closed
[CALCITE-1913] Make SqlDialect pluggable and remove DatabaseProduct uses#540beikov wants to merge 2 commits intoapache:masterfrom
beikov wants to merge 2 commits intoapache:masterfrom
Conversation
… and introduce a configurable SqlDialectFactory
7mming7
pushed a commit
to Kyligence/calcite
that referenced
this pull request
Jan 23, 2021
…, and introduce a configurable SqlDialectFactory (Christian Beikov) Create class SqlDialect.Context to hold all arguments to the constructor of a SqlDialect, including allowing future expansion. (Julian Hyde) Back out Christian's deprecation of DatabaseProduct. In my opinion, deprecation is a step too far. People can use it if they like, but there are usually better alternatives. (Julian Hyde) Close apache#540
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.