[CALCITE-1867] Allow creating additional grouped window functions #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianhyde
pushed a commit
to julianhyde/calcite
that referenced
this pull request
Oct 24, 2017
…her) Rename SqlGroupFunction to SqlGroupedWindowFunction. Close apache#549 Change-Id: I38b2d27e51d4b812cd1eb68868a5d2c7c1ece717
julianhyde
pushed a commit
to julianhyde/calcite
that referenced
this pull request
Nov 2, 2017
…her) Rename SqlGroupFunction to SqlGroupedWindowFunction. Close apache#549
XintaoLiao
pushed a commit
to XintaoLiao/calcite
that referenced
this pull request
Dec 5, 2017
…her) Rename SqlGroupFunction to SqlGroupedWindowFunction. Close apache#549
vvysotskyi
pushed a commit
to vvysotskyi/calcite
that referenced
this pull request
Dec 18, 2017
…her) Rename SqlGroupFunction to SqlGroupedWindowFunction. Close apache#549
7mming7
pushed a commit
to Kyligence/calcite
that referenced
this pull request
Jan 23, 2021
…her) Rename SqlGroupFunction to SqlGroupedWindowFunction. Close apache#549
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to creating additional grouped window functions. I chose
SqlGroupedWindowFunctionas a new name that also complies with the Java docs. This PR does not fully implement CALCITE-1867 (customAuxiliaryConverterfunctionality is still missing), but solves most of the problems we have at Apache Flink.