Skip to content

[CALCITE-1876] Create a rule to push the projections used in aggregate #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lfkpoa wants to merge 1 commit into from
Closed

[CALCITE-1876] Create a rule to push the projections used in aggregate #562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions example/csv/src/main/java/org/apache/calcite/adapter/csv/CsvTableScan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,14 @@
import org.apache.calcite.linq4j.tree.Expressions;
import org.apache.calcite.linq4j.tree.Primitive;
import org.apache.calcite.plan.RelOptCluster;
import org.apache.calcite.plan.RelOptCost;
import org.apache.calcite.plan.RelOptPlanner;
import org.apache.calcite.plan.RelOptTable;
import org.apache.calcite.plan.RelTraitSet;
import org.apache.calcite.rel.RelNode;
import org.apache.calcite.rel.RelWriter;
import org.apache.calcite.rel.core.TableScan;
import org.apache.calcite.rel.metadata.RelMetadataQuery;
import org.apache.calcite.rel.type.RelDataType;
import org.apache.calcite.rel.type.RelDataTypeFactory;
import org.apache.calcite.rel.type.RelDataTypeField;
Expand Down Expand Up @@ -79,6 +81,11 @@ protected CsvTableScan(RelOptCluster cluster, RelOptTable table,
planner.addRule(CsvProjectTableScanRule.INSTANCE);
}

@Override public RelOptCost computeSelfCost(RelOptPlanner planner, RelMetadataQuery mq) {
return super.computeSelfCost(planner, mq)
.multiplyBy(fields.length / table.getRowType().getFieldCount());
}

public Result implement(EnumerableRelImplementor implementor, Prefer pref) {
PhysType physType =
PhysTypeImpl.of(
Expand Down
24 changes: 24 additions & 0 deletions example/csv/src/test/java/org/apache/calcite/test/CsvTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,30 @@ public Void apply(ResultSet resultSet) {
.ok();
}

@Test public void testPushDownProjectAggregate() throws SQLException {
sql("smart", "explain plan for select gender, count(*) from EMPS group by gender")
.returns("PLAN=EnumerableAggregate(group=[{0}], EXPR$1=[COUNT()])\n"
+ " CsvTableScan(table=[[SALES, EMPS]], fields=[[3]])\n")
.ok();
}

@Test public void testPushDownProjectAggregateWithFilter() throws SQLException {
sql("smart", "explain plan for select max(empno) from EMPS where gender='F'")
.returns("PLAN=EnumerableAggregate(group=[{}], EXPR$0=[MAX($0)])\n"
+ " EnumerableCalc(expr#0..1=[{inputs}], expr#2=['F'], expr#3=[=($t1, $t2)], proj#0..1=[{exprs}], $condition=[$t3])\n"
+ " CsvTableScan(table=[[SALES, EMPS]], fields=[[0, 3]])\n")
.ok();
}

@Test public void testPushDownProjectAggregateNested() throws SQLException {
sql("smart", "explain plan for select gender, max(qty) from\n"
+ "(select name, gender, count(*) qty from EMPS group by name, gender) t group by gender")
.returns("PLAN=EnumerableAggregate(group=[{1}], EXPR$1=[MAX($2)])\n"
+ " EnumerableAggregate(group=[{0, 1}], QTY=[COUNT()])\n"
+ " CsvTableScan(table=[[SALES, EMPS]], fields=[[1, 3]])\n")
.ok();
}

@Test public void testFilterableSelect() throws SQLException {
sql("filterable-model", "select name from EMPS").ok();
}
Expand Down