CALCITE-2081 fix join two window function NPE#634
Closed
zinking wants to merge 1 commit intoapache:masterfrom
Closed
CALCITE-2081 fix join two window function NPE#634zinking wants to merge 1 commit intoapache:masterfrom
zinking wants to merge 1 commit intoapache:masterfrom
Conversation
zinking
force-pushed
the
CALCITE-2081
branch
from
71d8256 to
8bd572a
Compare
julianhyde
pushed a commit
to julianhyde/calcite
that referenced
this pull request
Feb 23, 2018
…OIN gives NullPointerException (Zhen Wang) Introduced a counter so that the two windows would have distinct variable names in generated code. Before this fix there was a NullPointerException during code generation. Remove an unused constant. Close apache#634
7mming7
pushed a commit
to Kyligence/calcite
that referenced
this pull request
Jan 23, 2021
…OIN throws NullPointerException (Zhen Wang) Fixed by introducing a counter so that the two windows would have distinct variable names in generated code. Before this fix there was a NullPointerException during code generation. Remove an unused constant. Close apache#634
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as Luis pointed out, the issue is because of the name collision between two window functions.
so adding a context to record the window function count to avoid collision is one possible fix.