[CALCITE-2287] StackOverflowError from FlatList equals()#682
Closed
zhong-j-yu wants to merge 1 commit intoapache:masterfrom
Closed
[CALCITE-2287] StackOverflowError from FlatList equals()#682zhong-j-yu wants to merge 1 commit intoapache:masterfrom
zhong-j-yu wants to merge 1 commit intoapache:masterfrom
Conversation
hsyuan
reviewed
Apr 27, 2018
| && Objects.equals(this.t2, that.t2); | ||
| } | ||
| return o.equals(this); | ||
| return Arrays.asList(t0, t1, t2).equals(o); |
Member
There was a problem hiding this comment.
Maybe better define a static variable to store Arrays.asList(t0, t1, t2)
or check o is instance of List with the same size with this before calling equals.
Author
There was a problem hiding this comment.
Thanks. I'll abandon this version, and hope for someone else to finish it while I'm on vacation:)
julianhyde
pushed a commit
to julianhyde/calcite
that referenced
this pull request
May 1, 2018
julianhyde
pushed a commit
to julianhyde/calcite
that referenced
this pull request
May 1, 2018
julianhyde
pushed a commit
to julianhyde/calcite
that referenced
this pull request
May 1, 2018
jcamachor
pushed a commit
to jcamachor/calcite
that referenced
this pull request
May 31, 2018
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Aug 28, 2025
Close apache#682 Change-Id: I45a792b43e73264f4e6c1e30bb9062e9dd6f0b6d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CALCITE-2287