[CALCITE-2290] Fix type issue while flattening#708
Closed
laurentgo wants to merge 1 commit intoapache:masterfrom
Closed
[CALCITE-2290] Fix type issue while flattening#708laurentgo wants to merge 1 commit intoapache:masterfrom
laurentgo wants to merge 1 commit intoapache:masterfrom
Conversation
Fix an issue during flattening of the rel structure where type nullability is removed from an expression during rewrite, by instructing RexBuilder#makeCast to preserve it.
vlsi
added
returned-with-feedback
Contributor
|
@laurentgo , I tried the test case on master 1.19.0-SNAPSHOT and it works. LogicalProject(RES2=[true]) Can you please close this PR? |
Member
|
@vlsi and @siddharthteotia observed that the test no longer fails in master 1.19.0-SNAPSHOT. Since @laurentgo didn't follow up I am closing this PR and the respective JIRA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue during flattening of the rel structure where type nullability
is removed from an expression during rewrite, by instructing
RexBuilder#makeCast to preserve it.