[CALCITE-2347] running ElasticSearch embedded mode in unit tests (for ES adapter) #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asereda-gs
changed the title
Member
|
@beikov Can you weigh in on this given your recent work on the ES? |
Contributor
|
I'm still on vacation so I can only have a deeper look next week. Overall this looks ok though. |
asereda-gs
force-pushed
the
fake-elasticsearch
branch
3 times, most recently
from
be61146 to
69e94dc
Compare
asereda-gs
force-pushed
the
fake-elasticsearch
branch
2 times, most recently
from
e5b0506 to
f397024
Compare
beikov
suggested changes
Jun 19, 2018
Contributor
beikov
left a comment
beikov
left a comment
There was a problem hiding this comment.
Apart from the question regarding the package, this looks good to me.
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.elasticsearch.node; |
Contributor
There was a problem hiding this comment.
Is it intended that this class is in this package rather than in the org.apache.calcite namespace?
Member
Author
There was a problem hiding this comment.
Hmm somehow I though that particular Node constructor is package private (which is not the case) LocalNode has been moved as inner class of EmbeddedNode. No more org.elasticsearch packages.
…of ES adapter (Andrei Sereda) After discussion on dev-list Integration tests (for ES) have been removed. They're now superseded by unit tests (which execute queries against a real elastic instance) Added local file (zips-mini.json) which contains a small subset of original zips.json (allows to bootstrap tests faster) Created separate ES JUnit rule which can be re-used across different tests. Both v2 and v5 of ES adapters are supported.
asereda-gs
force-pushed
the
fake-elasticsearch
branch
from
f397024 to
4c55691
Compare
Member
Author
|
That package has been removed. |
Contributor
|
Looks good to me now. Anything to add @michaelmior ? |
Member
|
Sorry for the delay. Looks good to me as well! |
snuyanzin
pushed a commit
to snuyanzin/calcite
that referenced
this pull request
Jun 26, 2018
…of ES adapter (Andrei Sereda) After discussion on dev-list Integration tests (for ES) have been removed. They're now superseded by unit tests (which execute queries against a real elastic instance) Added local file (zips-mini.json) which contains a small subset of original zips.json (allows to bootstrap tests faster) Created separate ES JUnit rule which can be re-used across different tests. Both v2 and v5 of ES adapters are supported. Close apache#716
wangxlong
pushed a commit
to wangxlong/calcite
that referenced
this pull request
Feb 13, 2020
…of ES adapter (Andrei Sereda) After discussion on dev-list Integration tests (for ES) have been removed. They're now superseded by unit tests (which execute queries against a real elastic instance) Added local file (zips-mini.json) which contains a small subset of original zips.json (allows to bootstrap tests faster) Created separate ES JUnit rule which can be re-used across different tests. Both v2 and v5 of ES adapters are supported. Close apache#716
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Aug 28, 2025
…of ES adapter (Andrei Sereda) After discussion on dev-list Integration tests (for ES) have been removed. They're now superseded by unit tests (which execute queries against a real elastic instance) Added local file (zips-mini.json) which contains a small subset of original zips.json (allows to bootstrap tests faster) Created separate ES JUnit rule which can be re-used across different tests. Both v2 and v5 of ES adapters are supported. Close apache#716 Change-Id: Ia068308cb4a8cd5dc624f5c59c5911e055959ad5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows ES adapter tests to run against real ElasticSearch resource. That instance is started programmatically and embedded in current java process (as part of junit test).
Major benefit of such setup is that there is no dependency on external resource (or process). Integration tests (for this adapter) can now run at build time improving test coverage of the library. Another convenience is that users can define their own indexes and data, validating more edge-cases (like booleans, nested documents unusual attribute names etc.) for this adapter.
This particular PR is a prelude towards aforementioned goal and doesn't contain actual IT tests (which currently fail). They will be corrected and migrated in a separate commit.