[CALCITE-2359] Fix inconsistent results casting single-field intervals to integers#730
Closed
jduo wants to merge 3 commits intoapache:masterfrom
Closed
[CALCITE-2359] Fix inconsistent results casting single-field intervals to integers#730jduo wants to merge 3 commits intoapache:masterfrom
jduo wants to merge 3 commits intoapache:masterfrom
Conversation
Ensure casting intervals to integers always returns the result in terms of the trailing unit. Previously we had the following behavior: - Casting a standalone day interval literal returned results in terms of the trailing unit. - Casting a standalone year interval literal returned results in terms of months. - Casting a day interval expression returned results in terms of milliseconds. - Casting a year interval expression returned results in terms of months.
jduo
changed the title
… (James Duong) Ensure casting intervals to integers always returns the result in terms of the trailing unit. Previously we had the following behavior: - Casting a standalone day interval literal returned results in terms of the trailing unit. - Casting a standalone year interval literal returned results in terms of months. - Casting a day interval expression returned results in terms of milliseconds. - Casting a year interval expression returned results in terms of months.
Member
|
Thanks for the contribution! It would make things easier to review if you could squash those three commits down to one. |
julianhyde
pushed a commit
to julianhyde/calcite
that referenced
this pull request
Jun 29, 2018
…mes Duong) Ensure casting intervals to integers always returns the result in terms of the trailing unit. Previously we had the following behavior: - Casting a standalone day interval literal returned results in terms of the trailing unit. - Casting a standalone year interval literal returned results in terms of months. - Casting a day interval expression returned results in terms of milliseconds. - Casting a year interval expression returned results in terms of months. Close apache#730
julianhyde
pushed a commit
to julianhyde/calcite
that referenced
this pull request
Jun 29, 2018
…mes Duong) Ensure casting intervals to integers always returns the result in terms of the trailing unit. Previously we had the following behavior: - Casting a standalone day interval literal returned results in terms of the trailing unit. - Casting a standalone year interval literal returned results in terms of months. - Casting a day interval expression returned results in terms of milliseconds. - Casting a year interval expression returned results in terms of months. Close apache#730
wangxlong
pushed a commit
to wangxlong/calcite
that referenced
this pull request
Feb 13, 2020
…mes Duong) Ensure casting intervals to integers always returns the result in terms of the trailing unit. Previously we had the following behavior: - Casting a standalone day interval literal returned results in terms of the trailing unit. - Casting a standalone year interval literal returned results in terms of months. - Casting a day interval expression returned results in terms of milliseconds. - Casting a year interval expression returned results in terms of months. Close apache#730
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Aug 28, 2025
…mes Duong) Ensure casting intervals to integers always returns the result in terms of the trailing unit. Previously we had the following behavior: - Casting a standalone day interval literal returned results in terms of the trailing unit. - Casting a standalone year interval literal returned results in terms of months. - Casting a day interval expression returned results in terms of milliseconds. - Casting a year interval expression returned results in terms of months. Close apache#730 Change-Id: Icf875d2277cc8efd323f2ac404bc7888d397080d
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Mar 16, 2026
…mes Duong) Ensure casting intervals to integers always returns the result in terms of the trailing unit. Previously we had the following behavior: - Casting a standalone day interval literal returned results in terms of the trailing unit. - Casting a standalone year interval literal returned results in terms of months. - Casting a day interval expression returned results in terms of milliseconds. - Casting a year interval expression returned results in terms of months. Close apache#730 Change-Id: Icf875d2277cc8efd323f2ac404bc7888d397080d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure casting single-field intervals to integers always returns the result in terms
of the trailing unit.
Previously we had the following behavior: