[CALCITE-2366] Add support for ANY_VALUE aggregate function#735
[CALCITE-2366] Add support for ANY_VALUE aggregate function#735gparai wants to merge 2 commits intoapache:masterfrom
Conversation
|
These planning changes look good. I was wondering if you have looked into the run-time changes in the Calcite executor for this agg function (for example |
|
@amansinha100 thanks for the review. I looked at the Calcite executor but did not completely understand it. It would be great if someone in the community could offer some insights (maybe some documentation or notes). Meanwhile, I will continue exploring it. |
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
Can any_value be used in order by clauses?
Is this a mon deterministic function?
|
@eolivelli thanks for the comment. Yes. Yes it is non deterministic (depends on implementation). Do you see an issue with this? |
|
@gparai no real problem from my side, I was just asking, |
gparai
force-pushed
the
CALCITE-2366-master
branch
from
42ee5e5 to
355a152
Compare
|
@julianhyde thank you so much for reviewing the PR. I have addressed your review comments. Please take a look. |
…arai) Close apache#735 Change-Id: Ie6a5380a7ff4ee934f4d2598c492d28033d5378c
…arai) Close apache#735 Change-Id: Ie6a5380a7ff4ee934f4d2598c492d28033d5378c
3 participants
Committers could you please review this PR? More details regarding the mailing list discussions are in the JIRA. Thanks!