[CALCITE-2422] Query with unnest of column from nested subquery fails when dynamic table is used#768
Closed
vvysotskyi wants to merge 1 commit intoapache:masterfrom
Closed
[CALCITE-2422] Query with unnest of column from nested subquery fails when dynamic table is used#768vvysotskyi wants to merge 1 commit intoapache:masterfrom
vvysotskyi wants to merge 1 commit intoapache:masterfrom
Conversation
snuyanzin
reviewed
Jul 26, 2018
| protected void validateUnnest(SqlCall call, SqlValidatorScope scope, RelDataType targetRowType) { | ||
| for (int i = 0; i < call.operandCount(); i++) { | ||
| SqlNode expandedItem = expand(call.operand(i), scope); | ||
| call.setOperand(i++, expandedItem); |
Contributor
There was a problem hiding this comment.
Not clear why it is required one more increment here. May be add an extra comment
Member
Author
There was a problem hiding this comment.
Sorry, I forget to remove it when replaced for each loop with for i. There shouldn't be one more increment. Thanks for pointing this.
… when dynamic table is used
Contributor
|
looks good from my side |
vvysotskyi
added a commit
to vvysotskyi/calcite
that referenced
this pull request
Jul 30, 2018
… when dynamic table is used Close apache#768 (cherry picked from commit 41a0677)
vvysotskyi
added a commit
to mapr/incubator-calcite
that referenced
this pull request
Jul 31, 2018
… when dynamic table is used Close apache#768 (cherry picked from commit 41a0677)
sergeyT2
pushed a commit
to sergeyT2/calcite
that referenced
this pull request
Aug 29, 2018
… when dynamic table is used Close apache#768
sergeyT2
pushed a commit
to sergeyT2/calcite
that referenced
this pull request
Aug 29, 2018
… when dynamic table is used Close apache#768
vvysotskyi
added a commit
to vvysotskyi/calcite
that referenced
this pull request
Dec 17, 2018
… when dynamic table is used Close apache#768 (cherry picked from commit 41a0677)
wangxlong
pushed a commit
to wangxlong/calcite
that referenced
this pull request
Feb 13, 2020
… when dynamic table is used Close apache#768
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Aug 28, 2025
… when dynamic table is used Close apache#768 Change-Id: Idfbe59fb42aa1fcd9f372f61641aacfec8993643
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.