[CALCITE-2537] Use litmus for VolcanoPlanner#validate#820
Closed
laurentgo wants to merge 1 commit intoapache:masterfrom
Closed
[CALCITE-2537] Use litmus for VolcanoPlanner#validate#820laurentgo wants to merge 1 commit intoapache:masterfrom
laurentgo wants to merge 1 commit intoapache:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VolcanoPlanner#validate() throws exception if validation fail, but this
only happens if the logger level is debug or finer. As changing log level
should not have control side effects, this might throw users off.
This change changes
void VolcanoPlanner#validate()intoboolean VolcanoPlanner#isValid(Litmus)and this method is only calledif assertions are enabled.