[CALCITE-2714] Slight optimization in SqlTypeFactoryImpl#createTypeWithNullability (Ruben Quesada Lopez)#947
Closed
rubenada wants to merge 1 commit intoapache:masterfrom
Closed
[CALCITE-2714] Slight optimization in SqlTypeFactoryImpl#createTypeWithNullability (Ruben Quesada Lopez)#947rubenada wants to merge 1 commit intoapache:masterfrom
rubenada wants to merge 1 commit intoapache:masterfrom
Conversation
julianhyde
added a commit
to julianhyde/calcite
that referenced
this pull request
Nov 29, 2018
Make BasicSqlType immutable, therefore we don't need to call clone. Close apache#947
julianhyde
added a commit
to julianhyde/calcite
that referenced
this pull request
Nov 29, 2018
Make BasicSqlType immutable, and now createWithNullability re-uses existing type if possible Make BasicSqlType immutable, therefore we don't need to call clone. Close apache#947
F21
pushed a commit
to F21/calcite
that referenced
this pull request
Jan 3, 2019
…eateWithNullability can reuse existing type if possible (Ruben Quesada Lopez) Close apache#947
wangxlong
pushed a commit
to wangxlong/calcite
that referenced
this pull request
Feb 13, 2020
…eateWithNullability can reuse existing type if possible (Ruben Quesada Lopez) Close apache#947
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Aug 28, 2025
…eateWithNullability can reuse existing type if possible (Ruben Quesada Lopez) Close apache#947 Change-Id: I4e47c297580699d12254e1eb1dedb62db09e5504
jamesstarr
pushed a commit
to jamesstarr/calcite
that referenced
this pull request
Mar 16, 2026
…eateWithNullability can reuse existing type if possible (Ruben Quesada Lopez) Close apache#947 Change-Id: I4e47c297580699d12254e1eb1dedb62db09e5504
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slight optimization in SqlTypeFactoryImpl#createTypeWithNullability