Skip to content

[CALCITE-2739] NPE is thrown if the DEFINE statement contains IN in MATCH_RECOGNIZE#970

Closed
dianfu wants to merge 1 commit intoapache:masterfrom
dianfu:CALCITE-2739
Closed

[CALCITE-2739] NPE is thrown if the DEFINE statement contains IN in MATCH_RECOGNIZE#970
dianfu wants to merge 1 commit intoapache:masterfrom
dianfu:CALCITE-2739

Conversation

@dianfu
Copy link
Contributor

@dianfu dianfu commented Dec 12, 2018

@dianfu dianfu changed the title [CALCITE-2739] NPE will thrown if the MEASURES statement contains IN in MATCH_RECOGNIZE [CALCITE-2739] NPE will thrown if the DEFINE statement contains IN in MATCH_RECOGNIZE Dec 13, 2018
@zinking
Copy link
Contributor

zinking commented Dec 13, 2018

change looks good to me.

@dianfu dianfu changed the title [CALCITE-2739] NPE will thrown if the DEFINE statement contains IN in MATCH_RECOGNIZE [CALCITE-2739] NPE will be thrown if the DEFINE statement contains IN in MATCH_RECOGNIZE Dec 13, 2018
@dianfu
Copy link
Contributor Author

dianfu commented Dec 14, 2018

@zinking Thanks a lot for your review.

Copy link
Member

@hsyuan hsyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hsyuan hsyuan added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Apr 12, 2019
@hsyuan hsyuan changed the title [CALCITE-2739] NPE will be thrown if the DEFINE statement contains IN in MATCH_RECOGNIZE [CALCITE-2739] NPE is thrown if the DEFINE statement contains IN in MATCH_RECOGNIZE Apr 12, 2019
@hsyuan hsyuan closed this in f2869e9 Apr 12, 2019
wangxlong pushed a commit to wangxlong/calcite that referenced this pull request Feb 13, 2020
jamesstarr pushed a commit to jamesstarr/calcite that referenced this pull request Aug 28, 2025
…ATCH_RECOGNIZE

Close apache#970

Change-Id: Ia0536239ac37596dc126e6d50a9ad3b326874361
jamesstarr pushed a commit to jamesstarr/calcite that referenced this pull request Mar 16, 2026
…ATCH_RECOGNIZE

Close apache#970

Change-Id: Ia0536239ac37596dc126e6d50a9ad3b326874361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LGTM-will-merge-soon Overall PR looks OK. Only minor things left.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants