[VIRTS-2188] Change Rule action to a dropdown selection instead of textbox

[emmanvg]

Description

Make "action:" under the rules modal a dropdown with the only valid options. In the past this would be a textbox that would allow any value, but in reality there are only two valid values ALLOW or DENY. Hence, it makes sense to simplify this form.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Go fact sources, click view sources, click add rule. Type a trait, a match and select a value from the dropdown modal ALLOW or DENY. Check under data/sources/UUID.yml that an entry exists with the proper ALLOW or DENY value. Re-open fact sources, load the test fact source and view the rules, check that nothing has changed.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

[codecov]

Codecov Report

Merging #2157 (b318593) into master (394852a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2157   +/-   ##
=======================================
  Coverage   66.43%   66.43%           
=======================================
  Files          70       70           
  Lines        5225     5225           
=======================================
  Hits         3471     3471           
  Misses       1754     1754           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 394852a...b318593. Read the comment docs.

[clenk]

LGTM; this has the exact same changes as #2144 which was approved by me and @b17zr.

[mrengstrom]

looks good to me