Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #2211 +/- ##
==========================================
- Coverage 68.10% 67.72% -0.39%
==========================================
Files 89 90 +1
Lines 6801 6958 +157
==========================================
+ Hits 4632 4712 +80
- Misses 2169 2246 +77
Continue to review full report at Codecov.
|
uruwhy
left a comment
uruwhy
left a comment
There was a problem hiding this comment.
Great work! Left some comments for organization and clarity on variable/function names. I do have one other request - could you provide more detail on the created directories, either in the PR description or somewhere in code comments? That way folks using or digging into the C2 have an idea on the directory structure, where files will end up on disk, etc
uruwhy
left a comment
uruwhy
left a comment
There was a problem hiding this comment.
Looking good! Few more small changes here and there
uruwhy
left a comment
uruwhy
left a comment
There was a problem hiding this comment.
Few more comments, plus the discussion about cwd + self.directory
|
Kudos, SonarCloud Quality Gate passed!
|
uruwhy
left a comment
uruwhy
left a comment
There was a problem hiding this comment.
Few more changes - clearer variable names, and turning duplicate code into a helper function. Looking great, and it's almost there!
3 participants
Description
Contact_ftp.py file to handle communication between CALDERA server and agent. Requierments.txt and conf/default.yml have been updated with relevant values. The ftp.py and ftp.go files will be added in a later pull request. The default.yml contains two directory values for ftp. The ftp.server.dir value is were the files that the agent generates during ftp c2 are stored (under their paw directory). For example if ftp.server.dir: /tmp/caldera, the files are stored under /caldera/tmp/caldera/paw.
Type of change
How Has This Been Tested?
Some pytesting has occurred (Not satisfactory, backlogged). Beaconing, uploading files, and downloading payloads has been tested with a sandcat agent on Linux and Windows 10 vms. Multiple agents can communicate at the same time.
Checklist: