Skip to content

[VIRTS-2880] Sources v2 API Pytests#2307

Merged
bleepbop merged 13 commits into
masterfrom
bleepbop/VIRTS-2880/sources-v2-pytests
Oct 12, 2021
Merged

[VIRTS-2880] Sources v2 API Pytests#2307
bleepbop merged 13 commits into
masterfrom
bleepbop/VIRTS-2880/sources-v2-pytests

Conversation

@bleepbop
Copy link
Copy Markdown
Contributor

@bleepbop bleepbop commented Oct 5, 2021

Description

Unit tests for v2 Sources API.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Verified tests passed for multiple versions of python using tox.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [NA] I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@bleepbop bleepbop marked this pull request as draft October 5, 2021 21:18
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 5, 2021

Codecov Report

Merging #2307 (82e0a14) into master (11f7a08) will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2307      +/-   ##
==========================================
+ Coverage   72.40%   72.57%   +0.17%     
==========================================
  Files         108      109       +1     
  Lines        7863     7916      +53     
==========================================
+ Hits         5693     5745      +52     
- Misses       2170     2171       +1     
Impacted Files Coverage Δ
app/api/v2/handlers/fact_source_api.py 96.22% <0.00%> (ø)
app/api/v2/responses.py 88.88% <0.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11f7a08...82e0a14. Read the comment docs.

@bleepbop bleepbop marked this pull request as ready for review October 6, 2021 12:55
@bleepbop bleepbop requested review from clenk and uruwhy October 6, 2021 12:55
@bleepbop bleepbop removed request for clenk and uruwhy October 6, 2021 13:20
@bleepbop bleepbop marked this pull request as draft October 6, 2021 13:21
@bleepbop bleepbop marked this pull request as ready for review October 7, 2021 02:08
@bleepbop bleepbop enabled auto-merge (squash) October 7, 2021 02:08
@bleepbop bleepbop requested review from clenk and uruwhy October 7, 2021 02:08
clenk
clenk previously approved these changes Oct 7, 2021
Copy link
Copy Markdown
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread tests/api/v2/handlers/test_sources_api.py Outdated
Co-authored-by: Chris Lenk <clenk@users.noreply.github.com>
@bleepbop bleepbop requested a review from clenk October 7, 2021 16:22
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bleepbop bleepbop merged commit 4da3bdc into master Oct 12, 2021
@bleepbop bleepbop deleted the bleepbop/VIRTS-2880/sources-v2-pytests branch October 12, 2021 21:07
cyber-arsenull pushed a commit that referenced this pull request Dec 28, 2021
* create test file

* add fixtures

* update nested object instantiation

* all tests passing

* add rules to test objects

* mock time for payload

* update parameters, remove unrelated test function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants