Skip to content

added pyminizip dependency from emu plugin#2322

Merged
mchan143 merged 2 commits into
masterfrom
pyminizip-dependency
Oct 19, 2021
Merged

added pyminizip dependency from emu plugin#2322
mchan143 merged 2 commits into
masterfrom
pyminizip-dependency

Conversation

@mchan143
Copy link
Copy Markdown
Contributor

Description

Added pyminizip dependency from emu plugin to CALDERA's requirements.txt

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Re-installed requirements using pip

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • [N/A] I have added tests that prove my fix is effective or that my feature works

Copy link
Copy Markdown
Contributor

@cmagone cmagone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mchan143 mchan143 requested a review from emmanvg October 18, 2021 14:02
Copy link
Copy Markdown
Contributor

@emmanvg emmanvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Related issue mitre/emu#21

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 19, 2021

Codecov Report

Merging #2322 (bd58c46) into master (1f35413) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2322   +/-   ##
=======================================
  Coverage   72.62%   72.62%           
=======================================
  Files         110      110           
  Lines        7942     7942           
=======================================
  Hits         5768     5768           
  Misses       2174     2174           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f35413...bd58c46. Read the comment docs.

@mchan143 mchan143 merged commit 9ab1527 into master Oct 19, 2021
@mchan143 mchan143 deleted the pyminizip-dependency branch October 19, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants