virts-2979 - Learning Service Fact Creation bugfix

[ArtificialErmine]

Description

In the current iteration of Caldera, it is possible for the learning service to generate facts that get added to a link's internal collection, but not to the overall operation's collection (duplicate protection differences due to scope, essentially). This patch addresses this by changing things so that fact storage is handled manually by the learning service, rather than delegated to the link.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

This has been tested by running Snag Broadcast IP (known as a trigger ability for this bug), and checking the results of the Debrief plugin (which revealed an issue with the Debrief plugin).

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• [NA] I have made corresponding changes to the documentation
• [NA] I have added tests that prove my fix is effective or that my feature works

[clenk]

LGTM

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[codecov]

Codecov Report

Merging #2340 (0fdbe63) into master (895c3ff) will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2340      +/-   ##
==========================================
+ Coverage   72.43%   72.60%   +0.16%     
==========================================
  Files         110      110              
  Lines        7938     7946       +8     
==========================================
+ Hits         5750     5769      +19     
+ Misses       2188     2177      -11     

Impacted Files	Coverage Δ
app/service/learning_svc.py	87.32% <ø> (-0.18%)	⬇️
app/service/app_svc.py	50.86% <0.00%> (-0.90%)	⬇️
app/service/file_svc.py	62.44% <0.00%> (-0.30%)	⬇️
app/contacts/contact_slack.py	34.09% <0.00%> (-0.16%)	⬇️
app/contacts/contact_tcp.py	46.31% <0.00%> (+0.07%)	⬆️
app/service/planning_svc.py	84.44% <0.00%> (+0.11%)	⬆️
app/contacts/contact_gist.py	50.76% <0.00%> (+8.92%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 895c3ff...0fdbe63. Read the comment docs.