Change global styles to accomodate changes in debrief#2341
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2341 +/- ##
=======================================
Coverage 72.59% 72.59%
=======================================
Files 110 110
Lines 7947 7947
=======================================
Hits 5769 5769
Misses 2178 2178 Continue to review full report at Codecov.
|
iguannalin
approved these changes
Nov 6, 2021
mchan143
approved these changes
Nov 12, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
cyber-arsenull
pushed a commit
that referenced
this pull request
Dec 28, 2021
* Change global styles to accomodate changes in debrief
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









Description
Debrief is using some components from Bulma that have not yet been styled to match the rest of the site. Since other plugins may use these components, the global styles have been changed here. There are also some shared JS changes to accommodate changes in debrief and potentially other plugins in the future.
Type of change
How Has This Been Tested?
These changes, in tandem with a PR in debrief, allow the new UI of the plugin to function correctly.
Checklist: