Skip to content

Change global styles to accomodate changes in debrief#2341

Merged
argaudreau merged 5 commits into
masterfrom
debrief_styles
Nov 16, 2021
Merged

Change global styles to accomodate changes in debrief#2341
argaudreau merged 5 commits into
masterfrom
debrief_styles

Conversation

@argaudreau
Copy link
Copy Markdown
Contributor

Description

Debrief is using some components from Bulma that have not yet been styled to match the rest of the site. Since other plugins may use these components, the global styles have been changed here. There are also some shared JS changes to accommodate changes in debrief and potentially other plugins in the future.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

These changes, in tandem with a PR in debrief, allow the new UI of the plugin to function correctly.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@argaudreau argaudreau requested a review from iguannalin November 1, 2021 14:01
Copy link
Copy Markdown
Contributor

@iguannalin iguannalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! Only small UI fix I'd suggest is fixing the oddly left-padded red underline in the bottom table, so it matches the length of the line under the header at the top as well.

Screen Shot 2021-11-01 at 12 04 06

@argaudreau argaudreau requested a review from mchan143 November 4, 2021 17:43
@argaudreau argaudreau requested a review from iguannalin November 4, 2021 17:49
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 4, 2021

Codecov Report

Merging #2341 (7e8bd0b) into master (2cc8339) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2341   +/-   ##
=======================================
  Coverage   72.59%   72.59%           
=======================================
  Files         110      110           
  Lines        7947     7947           
=======================================
  Hits         5769     5769           
  Misses       2178     2178           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cc8339...7e8bd0b. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@argaudreau argaudreau merged commit 9b43a7f into master Nov 16, 2021
@argaudreau argaudreau deleted the debrief_styles branch November 16, 2021 14:58
cyber-arsenull pushed a commit that referenced this pull request Dec 28, 2021
* Change global styles to accomodate changes in debrief
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants