Moved confetti.min.js to core library, updated training plugin with completed certificate message#2342
Merged
Merged
Conversation
…ompleted certificate message
argaudreau
previously approved these changes
Nov 1, 2021
Contributor
argaudreau
left a comment
argaudreau
left a comment
There was a problem hiding this comment.
Looks good! The confetti is a must have 🎉
iguannalin
dismissed stale reviews from trich2213 and argaudreau
via
2bfa59e
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #2342 +/- ##
=======================================
Coverage 72.60% 72.60%
=======================================
Files 110 110
Lines 7946 7946
=======================================
Hits 5769 5769
Misses 2177 2177 Continue to review full report at Codecov.
|
argaudreau
approved these changes
Nov 10, 2021
trich2213
approved these changes
Nov 10, 2021
cyber-arsenull
pushed a commit
that referenced
this pull request
Dec 28, 2021
…ompleted certificate message (#2342)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Confetti.min.js is no longer working in training plugin due to import issues with Alpine, now moved to shared core library so it can preloaded before the training plugin. Pinned training plugin to latest version.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: