Skip to content

Ops UI fix#2368

Merged
wbooth merged 9 commits into
masterfrom
ops-ui-fix
Dec 1, 2021
Merged

Ops UI fix#2368
wbooth merged 9 commits into
masterfrom
ops-ui-fix

Conversation

@iguannalin
Copy link
Copy Markdown
Contributor

@iguannalin iguannalin commented Nov 22, 2021

Description

Fixes errors with fetching timestamps, undefined error with operations without link. Added fact-highlighting in view output modal, and moved download button to more visible place

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@iguannalin iguannalin self-assigned this Nov 22, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 22, 2021

Codecov Report

Merging #2368 (7f577ce) into master (b478416) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2368   +/-   ##
=======================================
  Coverage   72.74%   72.74%           
=======================================
  Files         110      110           
  Lines        7948     7948           
=======================================
  Hits         5782     5782           
  Misses       2166     2166           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b478416...7f577ce. Read the comment docs.

@iguannalin iguannalin marked this pull request as draft November 22, 2021 20:56
@iguannalin iguannalin removed the request for review from argaudreau November 22, 2021 20:56
@iguannalin iguannalin marked this pull request as ready for review November 23, 2021 14:28
Copy link
Copy Markdown
Contributor

@argaudreau argaudreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small tweaks then it's good to go!

Comment thread templates/operations.html Outdated
Comment thread templates/operations.html
Comment thread templates/operations.html Outdated
…timestamp to more readable format based JS-native function toLocaleString(); show Download button only if an operation is selected
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@iguannalin iguannalin requested a review from wbooth November 29, 2021 21:19
@wbooth wbooth merged commit 499e7c0 into master Dec 1, 2021
@wbooth wbooth deleted the ops-ui-fix branch December 1, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants