Skip to content

VIRTS-3151 Agents HEAD/GET/POST documentation#2398

Merged
wbooth merged 7 commits into
apache:masterfrom
yee-jonathan:VIRTS---3151-Agents-HEAD/GET/POST-Documentation
Dec 22, 2021
Merged

VIRTS-3151 Agents HEAD/GET/POST documentation#2398
wbooth merged 7 commits into
apache:masterfrom
yee-jonathan:VIRTS---3151-Agents-HEAD/GET/POST-Documentation

Conversation

@yee-jonathan
Copy link
Copy Markdown
Contributor

Description

Adding API documentation for /agents endpoint.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Added summary and description documentation to /agents endpoint. After navigating to api docs, confirmed that summary and description appear under the appropriate agent field with the correct formatting.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@yee-jonathan yee-jonathan added the documentation Changes to instructions or explanations of features. label Dec 14, 2021
Comment thread app/api/v2/handlers/agent_api.py Outdated
Copy link
Copy Markdown
Contributor

@bleepbop bleepbop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny change, everything else looks good to me

Copy link
Copy Markdown
Contributor Author

@yee-jonathan yee-jonathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed line 35 to be in Flake8 compliance

Comment thread app/api/v2/handlers/agent_api.py Outdated
Copy link
Copy Markdown
Contributor

@bleepbop bleepbop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change in the GET /agents description and it should be good to go!

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yee-jonathan
Copy link
Copy Markdown
Contributor Author

Changed wording in lines 31 and 34 to more accurately reflect how a GET for /agents is handled

@yee-jonathan yee-jonathan removed the request for review from ArtificialErmine December 21, 2021 05:44
@wbooth wbooth merged commit f4d6973 into apache:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Changes to instructions or explanations of features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants