Skip to content

Update health_api.py#2411

Merged
bernsteinj merged 2 commits into
masterfrom
bernsteinj-patch-1
Dec 20, 2021
Merged

Update health_api.py#2411
bernsteinj merged 2 commits into
masterfrom
bernsteinj-patch-1

Conversation

@bernsteinj
Copy link
Copy Markdown
Contributor

@bernsteinj bernsteinj commented Dec 20, 2021

Description

Adding docs to health endpoint

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Automated test.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Adding docs to health endpoint.
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wohoo! Your first PR -- thanks for contributing!

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 20, 2021

Codecov Report

Merging #2411 (4fd2eb5) into master (970492a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2411   +/-   ##
=======================================
  Coverage   73.22%   73.22%           
=======================================
  Files         112      112           
  Lines        8068     8068           
=======================================
  Hits         5908     5908           
  Misses       2160     2160           
Impacted Files Coverage Δ
app/api/v2/handlers/health_api.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 970492a...4fd2eb5. Read the comment docs.

Copy link
Copy Markdown
Contributor

@wbooth wbooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@aapplebaum aapplebaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@bernsteinj bernsteinj merged commit 7e323ea into master Dec 20, 2021
@bernsteinj bernsteinj deleted the bernsteinj-patch-1 branch December 20, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants