Add paw to existing Fact only if Fact wasn't used in Link command#2432
Merged
Conversation
Merged
3 tasks
ArtificialErmine
approved these changes
Jan 6, 2022
Contributor
ArtificialErmine
left a comment
ArtificialErmine
left a comment
There was a problem hiding this comment.
LGTM, nice use of the existing data structures to filter out what already has been processed.
Contributor
Author
|
@cmagone if all looks good, I can merge once you approve the proposed changes. Thanks! |
cmagone
reviewed
Jan 7, 2022
cmagone
approved these changes
Jan 7, 2022
|
Kudos, SonarCloud Quality Gate passed! |
navnitan-7
added a commit
to navnitan-7/caldera
that referenced
this pull request
Mar 30, 2026
Mirror upstream jQuery apachegh-2432 fix in vendored ajaxConvert: skip automatic script conversion on cross-domain responses unless dataType was explicit. Refs: jquery/jquery@2546bb3 Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up bug fix to #2397. This change proposes that paws are only added to a Fact's
collected_byif they were not used in the command, which resolves the issue when relationships are created for seeded facts and seeded facts go through thesave_factprocess. Seeded facts should not be updated to show they have been collected by an agent if they were only used in the command.The proposed change also resolves the scenario where an operation started with a seeded fact (say
domain.user.name) and further discovery actions by an agent led to the re-discovery of the same fact. The paw will be added to a Fact'scollected_byin this case.Type of change
How Has This Been Tested?
collected_by.Checklist: